Skip to content

Catch uninstallation AND removal in the same change!#120

Closed
bserem wants to merge 3 commits into
mainfrom
uninstall-and-remove-check
Closed

Catch uninstallation AND removal in the same change!#120
bserem wants to merge 3 commits into
mainfrom
uninstall-and-remove-check

Conversation

@bserem
Copy link
Copy Markdown
Collaborator

@bserem bserem commented Apr 17, 2026

No description provided.

Copy link
Copy Markdown
Collaborator Author

bserem commented May 16, 2026

Hey @bserem — great idea here, but sanity-check has been refactored since this PR was opened. Checks now live in individual files under commands/host/_lib/ rather than inline in the main script, which is why this branch has conflicts.

I've done a reroll in #121 that ports the same logic to the new modular format:

  • The uninstall-safety check moves to _lib/check-drupal-safe-uninstall.sh
  • critical_fail() / bail_if_critical() are defined in the main script so all lib files can use them
  • The pre-push hook changes are carried over as-is

Closing this one as stale in favour of #121.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

bserem commented May 16, 2026

Correction: the reroll PR is #131, not #121. Sorry for the noise!


Generated by Claude Code

@bserem
Copy link
Copy Markdown
Collaborator Author

bserem commented May 16, 2026

I love how Claude code is impersonating me and chats with me too.

Either way, new PR is valid. This one needs to be closed.

@bserem bserem closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant